Skip to content

Conversation

crlf0710
Copy link
Member

Add #[doc(inline)] in std::task to make the nightly docs seem right.

Add #[doc(inline)] in `std::task` to make the doc seem right.
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2018
@Mark-Simulacrum
Copy link
Member

r? @QuietMisdreavus

@QuietMisdreavus
Copy link
Contributor

Unfortunately, because of #51252, this won't actually do anything. If you want the items to appear in the re-exported documentation, you'll need to re-export them one-by-one.

@crlf0710
Copy link
Member Author

@QuietMisdreavus Since this PR is not nominated at all, do you feel that #51252 will be resolved in the near future? (e.g. Before Rust 2018 arrives or something like that.) I mean, should i mark this pr blocked or just close it?

@QuietMisdreavus
Copy link
Contributor

I would personally like to work on fixing that issue. I have a couple other PRs in-flight at the moment, but once one of those lands i would like to turn my attention to that one. In fact, i'll go ahead and accept this so that it can immediately benefit when that happens.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 11, 2018

📌 Commit 02c96d4 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2018
@bors
Copy link
Collaborator

bors commented Jun 11, 2018

⌛ Testing commit 02c96d4 with merge 0d76317...

bors added a commit that referenced this pull request Jun 11, 2018
Add #[doc(inline)] in std::task

Add #[doc(inline)] in `std::task` to make the nightly docs seem right.
@bors
Copy link
Collaborator

bors commented Jun 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 0d76317 to master...

@bors bors merged commit 02c96d4 into rust-lang:master Jun 11, 2018
@crlf0710 crlf0710 deleted the patch-2 branch June 11, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants